On Tue, 24 Feb 2015 16:12:40 -0500
Andrew W Elble <aweits@xxxxxxx> wrote:
>
> We're running into something very similar.
>
>
> fs/nfsd/nfs4state.c:
>
> 1631 static void
> 1632 __destroy_client(struct nfs4_client *clp)
> 1633 {
>
> <snip>
>
> 1652 while (!list_empty(&clp->cl_revoked)) {
> 1653 dp = list_entry(reaplist.next, struct nfs4_delegation, dl_recall_lru);
> 1654 list_del_init(&dp->dl_recall_lru);
> 1655 nfs4_put_stid(&dp->dl_stid);
> 1656 }
>
> shouldn't that be:
>
> 1653 dp = list_entry(clp->cl_revoked.next, struct nfs4_delegation, dl_recall_lru);
>
> see commit 2d4a532d385f635ab8243b88db3136bb52a0bc29
>
> ?
>
> Thanks,
>
> Andy
>
(cc'ing Bruce)
Oh my, yes. Well spotted!
That's almost certainly _a_ problem if not _the_ problem. Looks like
commit 2d4a532d3 is what broke it.
Care to spin up a patch? If not, I'll do so as soon as I'm able. That's
almost certainly something that should go to stable as well.
--
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
