On Wed, Feb 15, 2012 at 01:50:28AM +0000, Myklebust, Trond wrote: > On Tue, 2012-02-14 at 19:53 -0500, J. Bruce Fields wrote: > > On Wed, Feb 15, 2012 at 12:43:08AM +0000, Myklebust, Trond wrote: > > > Then we have a problem. The zero initialisation is already in use out > > > there in both commercial and non-commercial versions of Linux. It is too > > > late to change that now. > > > > > > Furthermore, since none of the servers we've tested against in earlier > > > Bakeathons and Connectathons have complained, I suggest that we rather > > > change the spec with an errata. > > > > Argh. > > > > I just noticed that the server was crashing intermittently and traced it > > to incorrect handling of the case where the client sends a one-op > > SEQUENCE compound with seqid 0. I'm not sure why it started popping up > > just in 3.3--perhaps some change in the way the client uses slots made > > that more likely. > > > > The server code actually looks like it did assume initial seqid 1, but > > accepted initial seqid 0 (except in this one case) basically by mistake. > > > > In any case, I think it should be easy enough to teach it just to accept > > any seqid on a previously unused slot, so I'll do that.... > > Hang on... Looking at 3.2, I think you're correct. We used to initialise > to 1, and now we're initialising to 0. OK. I'll continue with my current fix, in that case, so using initial sequenceid 0 will result in a MISORDERED error. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
