Re: [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 15, 2012 at 12:43:08AM +0000, Myklebust, Trond wrote:
> Then we have a problem. The zero initialisation is already in use out
> there in both commercial and non-commercial versions of Linux. It is too
> late to change that now.
> 
> Furthermore, since none of the servers we've tested against in earlier
> Bakeathons and Connectathons have complained, I suggest that we rather
> change the spec with an errata.

Argh.

I just noticed that the server was crashing intermittently and traced it
to incorrect handling of the case where the client sends a one-op
SEQUENCE compound with seqid 0.  I'm not sure why it started popping up
just in 3.3--perhaps some change in the way the client uses slots made
that more likely.

The server code actually looks like it did assume initial seqid 1, but
accepted initial seqid 0 (except in this one case) basically by mistake.

In any case, I think it should be easy enough to teach it just to accept
any seqid on a previously unused slot, so I'll do that....

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux