This looks correct to me. This same bug - where the ivalue is ignored,
is in v2.6.39 and v3.2.
-->Andy
On Tue, Feb 14, 2012 at 4:48 PM, Vitaliy Gusev <gusev.vitaliy@xxxxxxxxx> wrote:
> Uninitialized seq_nr causes sending first SESSION request
> with sa_sequenceid = 0.
>
> Signed-off-by: Vitaliy Gusev <gusev.vitaliy@xxxxxxxxxxx>
> ---
> fs/nfs/nfs4proc.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index f0c849c..711a812 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5067,6 +5067,7 @@ static int nfs4_init_slot_table(struct nfs4_slot_table *tbl,
> int max_slots, int ivalue)
> {
> struct nfs4_slot *slot;
> + int i;
> int ret = -ENOMEM;
>
> BUG_ON(max_slots > NFS4_MAX_SLOT_TABLE);
> @@ -5082,6 +5083,8 @@ static int nfs4_init_slot_table(struct nfs4_slot_table *tbl,
> tbl->max_slots = max_slots;
> tbl->slots = slot;
> tbl->highest_used_slotid = -1; /* no slot is currently used */
> + for (i = 0; i < tbl->max_slots; ++i)
> + tbl->slots[i].seq_nr = ivalue;
> spin_unlock(&tbl->slot_tbl_lock);
> dprintk("%s: tbl=%p slots=%p max_slots=%d\n", __func__,
> tbl, tbl->slots, tbl->max_slots);
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
