On Aug. 18, 2010, 23:27 +0300, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: >> +++ b/include/linux/nfs4_pnfs.h >> @@ -0,0 +1,15 @@ >> +/* >> + * include/linux/nfs4_pnfs.h > > Please don't include these kinds of comments, they only purpose they > serve is frequently getting out of date. That applies to just about > every file added in this series. > Agreed. >> + * >> + * Common data structures needed by the pnfs client and pnfs layout driver. >> + * >> + * Copyright (c) 2002 The Regents of the University of Michigan. >> + * All rights reserved. >> + * >> + * Dean Hildebrand <dhildebz@xxxxxxxxxxxxxx> >> + */ >> + >> +#ifndef LINUX_NFS4_PNFS_H >> +#define LINUX_NFS4_PNFS_H >> + >> +#endif /* LINUX_NFS4_PNFS_H */ > > Adding a file that only contains copyrights and inclusion headers is > rather odd. I think you want your split a little more corse grained. > Yup. This was originally done for patch mechanics reasons. It can be just part of the first patch that uses the file. Benny -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
