On Aug. 18, 2010, 23:29 +0300, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: >> +#ifdef CONFIG_NFS_V4_1 >> + err = pnfs_initialize(); >> + if (err) >> + goto out00; >> +#endif /* CONFIG_NFS_V4_1 */ > > Unless the pnfs code goes into it's own module anyway this really > screams for stubs for the !CONFIG_NFS_V4_1 case to avoid all the > ifdef mess. > In this case we followed the existing "style" in this function. That said, I agree that a stub for CONFIG_NFS_V4_1 will work better. Benny -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
