On Fri, Aug 13, 2010 at 05:31:17PM -0400, andros@xxxxxxxxxx wrote: > From: The pNFS Team <linux-nfs@xxxxxxxxxxxxxxx> > > Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> If you split out the Kconfig from the code it guards it should come last in the series so that the code can't be enabled until it's complete. > depends on NFS_V4 && EXPERIMENTAL > help > This option enables support for minor version 1 of the NFSv4 protocol > - (draft-ietf-nfsv4-minorversion1) in the kernel's NFS client. > + (RFC5661) including support for the parallel NFS (pNFS) features > + in the kernel's NFS client. > + > + Unless you're an NFS developer, say N. How much code does the pnfs support add to the nfs.ko module? Just including this unconditionally might not be an all that good idea. Also Trond seemed to be pretty determined to split up nfs.ko into version specific modules, and pnfs and the various layout drivers are pretty good candidates for that. Maybe the pnfs patches should be ontop of that? > +config PNFS_FILE_LAYOUT > + tristate "NFS client support for the pNFS nfs-files layout (DEVELOPER ONLY)" > + depends on NFS_FS && NFS_V4_1 is it really developers-only at this point? And if it is so why doesn't it depend on EXPERIMENTAL > + default y defaulting to y for random fringe features is frowned upon. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
