Re: [PATCH][nfs-utils] configuration: Fix a typo in configure.ac

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 20, 2010 at 03:45:10PM -0800, Trond Myklebust wrote:
> From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> 
> Fix a typo in commit 6d5ac3fa (nfsd: Disble NFS 4.1 functionality by default).

Better: please just rever 6d5ac3fa and apply
http://marc.info/?l=linux-nfs&m=126540028610022&w=2

	- distributions shouldn't be turning on 4.1 by default yet.
	  Even if no clients *use* it by default, future clients will,
	  even with older servers that shouldn't have had 4.1 on yet.
	- In addition to the bug Trond found, 6d5ac3fa also
	  inadvertently disables -N4 in the disable_nfsv41 case.

--b.

> 
> We did not really intend to make NFSv4.0 support conditional on NFSv4.1
> being enabled.
> 
> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> ---
> 
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/configure.ac b/configure.ac
> index b7520d8..518b6d8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -81,7 +81,7 @@ AC_ARG_ENABLE(nfsv41,
>  	if test "$enable_nfsv41" = yes; then
>  		AC_DEFINE(NFS41_SUPPORTED, 1, [Define this if you want NFSv41 support compiled in])
>  	else
> -		enable_nfsv4=
> +		enable_nfsv41=
>  	fi
>  	AC_SUBST(enable_nfsv41)
>  	AM_CONDITIONAL(CONFIG_NFSV41, [test "$enable_nfsv41" = "yes"])
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux