On 02/22/2010 01:22 PM, J. Bruce Fields wrote: > On Sat, Feb 20, 2010 at 03:45:10PM -0800, Trond Myklebust wrote: >> From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> >> >> Fix a typo in commit 6d5ac3fa (nfsd: Disble NFS 4.1 functionality by default). > > Better: please just rever 6d5ac3fa and apply > http://marc.info/?l=linux-nfs&m=126540028610022&w=2 The problem I saw with the this patch was it would take a code change to re-enable the 4.1 functional, verses a enabling a configuration flag. Plus, there has been a precedence set of having these types of configuration flags, note the enable_nfsv3, enable_nfsv4, so adding a enable_nfsv41 seem to me made sense... > > - distributions shouldn't be turning on 4.1 by default yet. Its not... If the --enable_nfsv41 is not set, the 4.1 functional is off. Having this type of flag enables the distros to enable the functionality on development kernels but disable it on stable kernels, without any additional patches. Again to me, its seems like the cleanest way to do it... > - In addition to the bug Trond found, 6d5ac3fa also > inadvertently disables -N4 in the disable_nfsv41 case. Fixed... steved. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
