On Thu, Aug 21, 2008 at 7:05 PM, Chuck Lever <chucklever@xxxxxxxxx> wrote: > On Thu, Aug 21, 2008 at 6:54 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: >> On Thu, Aug 21, 2008 at 06:22:02PM -0400, Chuck Lever wrote: >>> I don't think you want to add a lot of specialized logic in >>> nfs4namespace.c or client.c or where ever that has to figure out what >>> a valid IP address string looks like. Just hand the referral hostname >>> string to the super.c address parser. That's what it's there for. >>> >>> If something comes out, it's almost sure to be a valid address. If >>> you have a scope ID too, then it's unsupported for now, and punt. You >>> can also explicitly check for a link-local address (there is a >>> facility for that) and punt in that case too. >> >> The case where the scope id is bad or the kstrndup() in >> nfs_parse_ipv6_scope_id fails seems to be indistinguishable from the >> case where there is no scope id specified. > > This sounds like nfs_parse_ipv6_scope_id() is broken. You mean if the > hostname just ends with a '%' ? I just sent you a patch that should address this issue. Compile-tested only. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
