On Wed, Aug 20, 2008 at 5:29 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > On Wed, Aug 20, 2008 at 05:19:50PM -0400, Chuck Lever wrote: >> On Wed, Aug 20, 2008 at 4:47 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: >> > On Wed, Aug 20, 2008 at 04:19:48PM -0400, Chuck Lever wrote: >> >> On Wed, Aug 20, 2008 at 4:08 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: >> >> > On Fri, Aug 15, 2008 at 12:59:09PM -0400, Chuck Lever wrote: >> >> >> On Aug 14, 2008, at 6:30 PM, J. Bruce Fields wrote: >> >> >>> I was looking back at this bug with the misparsing of >> >> >>> (non-mull-terminated) fs_locations attributes. Thanks to the work on >> >> >>> nfs_parse_server_address, etc., we can now also more easily support >> >> >>> ipv6 >> >> >>> addresses here. But I got lost in the usual maze of twisty struct >> >> >>> sockaddr_*'s, all alike. Is this right? Does any of it need to be >> >> >>> under CONFIG_IPV6? Is there a simpler way? >> >> >> >> >> >> The use of the new address parser looks correct, but your string >> >> >> handling needs work. :-) >> >> >> >> >> >> Comments below... >> >> > >> >> > Pffft. My hope that someone else would pick this up for me was >> >> > obviously fantasy. OK, thanks for comments: >> >> > >> >> >>> diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c >> >> >>> index b112857..c0f5191 100644 >> >> > ... >> >> >>> + if (memchr(buf->data, '%', buf->len)) >> >> >>> + goto next; >> >> >> >> >> >> Why are you looking for a '%' ? >> >> > >> >> > Would it have been clearer if I'd moved the IPV6_SCOPE_DELIMITER define >> >> > to a common header? I don't think that has any place in the nfs >> >> > protocol. And we've got less trust in the address we're parsing here >> >> > (which came across the wire) then we would in a mount commandline. >> >> >> >> OK, so you wanted a scope delimiter. Why do you want to punt IPv6 >> >> addresses that have a scope delimiter? Sorry to be dense. >> > >> > The thing we're parsing here is a hostname that the server returned to >> > us. It should be either a dns name (which we don't handle yet) or an ip >> > address. The scope-delimiter thing isn't legal. >> >> Scope delimiters are legal in IPv6 addresses. Unfortunately I can't >> find the relevant RFC at the moment. > > Oh, OK, I think I took a quick look and assumed they were something that > only made sense locally. I'll look again. What may be confusing you is that scope delimiters are used almost exclusively for link-local addresses, which are valid only on the local host. If you don't want to handle a referral that uses a link-local address, or you don't want to handle a link-local address with a scope ID, then there are explicit checks you can do. -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
