On Wed, Aug 20, 2008 at 4:08 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > On Fri, Aug 15, 2008 at 12:59:09PM -0400, Chuck Lever wrote: >> On Aug 14, 2008, at 6:30 PM, J. Bruce Fields wrote: >>> I was looking back at this bug with the misparsing of >>> (non-mull-terminated) fs_locations attributes. Thanks to the work on >>> nfs_parse_server_address, etc., we can now also more easily support >>> ipv6 >>> addresses here. But I got lost in the usual maze of twisty struct >>> sockaddr_*'s, all alike. Is this right? Does any of it need to be >>> under CONFIG_IPV6? Is there a simpler way? >> >> The use of the new address parser looks correct, but your string >> handling needs work. :-) >> >> Comments below... > > Pffft. My hope that someone else would pick this up for me was > obviously fantasy. OK, thanks for comments: > >>> diff --git a/fs/nfs/nfs4namespace.c b/fs/nfs/nfs4namespace.c >>> index b112857..c0f5191 100644 > ... >>> + if (memchr(buf->data, '%', buf->len)) >>> + goto next; >> >> Why are you looking for a '%' ? > > Would it have been clearer if I'd moved the IPV6_SCOPE_DELIMITER define > to a common header? I don't think that has any place in the nfs > protocol. And we've got less trust in the address we're parsing here > (which came across the wire) then we would in a mount commandline. OK, so you wanted a scope delimiter. Why do you want to punt IPv6 addresses that have a scope delimiter? Sorry to be dense. Are you just looking for "illegal" or confusing characters? The address parser should handle all that and give you an AF_UNSPEC address if the string had any weirdness in it. Otherwise, if the returned sockaddr is an IPv6 address, can you just check if the sin6_scope_ip field is not zero? -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
