Re: [PATCH 3/4] nfs: prepare to share nfs_set_port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 20, 2008 at 4:10 PM, J. Bruce Fields <bfields@xxxxxxxxxxxxxx> wrote:
> We plan to use this function elsewhere.
>
> Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
> ---
>  fs/nfs/internal.h |   20 ++++++++++++++++++++
>  fs/nfs/super.c    |   19 -------------------
>  2 files changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
> index 24241fc..0b30f24 100644
> --- a/fs/nfs/internal.h
> +++ b/fs/nfs/internal.h
> @@ -276,3 +276,23 @@ unsigned int nfs_page_array_len(unsigned int base, size_t len)
>                PAGE_SIZE - 1) >> PAGE_SHIFT;
>  }
>
> +

Extra blank line here.

> +/*
> + * Set the port number in an address.  Be agnostic about the address
> + * family.
> + */
> +static inline void nfs_set_port(struct sockaddr *sap, unsigned short port)
> +{
> +       switch (sap->sa_family) {
> +       case AF_INET: {
> +             struct sockaddr_in *ap = (struct sockaddr_in *)sap;
> +             ap->sin_port = htons(port);
> +             break;
> +       }
> +       case AF_INET6: {
> +              struct sockaddr_in6 *ap = (struct sockaddr_in6 *)sap;
> +              ap->sin6_port = htons(port);
> +              break;
> +       }
> +       }
> +}

Before Trond sees this and busts a blood vessel... you should refactor
the switch statement to get rid of the double braces.

-- 
Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux