On Wed, Aug 20, 2008 at 04:23:23PM -0400, Chuck Lever wrote:
> On Wed, Aug 20, 2008 at 4:10 PM, J. Bruce Fields <bfields@xxxxxxxxxxxxxx> wrote:
> > We plan to use this function elsewhere.
> >
> > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
> > ---
> > fs/nfs/internal.h | 20 ++++++++++++++++++++
> > fs/nfs/super.c | 19 -------------------
> > 2 files changed, 20 insertions(+), 19 deletions(-)
> >
> > diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
> > index 24241fc..0b30f24 100644
> > --- a/fs/nfs/internal.h
> > +++ b/fs/nfs/internal.h
> > @@ -276,3 +276,23 @@ unsigned int nfs_page_array_len(unsigned int base, size_t len)
> > PAGE_SIZE - 1) >> PAGE_SHIFT;
> > }
> >
> > +
>
> Extra blank line here.
>
> > +/*
> > + * Set the port number in an address. Be agnostic about the address
> > + * family.
> > + */
> > +static inline void nfs_set_port(struct sockaddr *sap, unsigned short port)
> > +{
> > + switch (sap->sa_family) {
> > + case AF_INET: {
> > + struct sockaddr_in *ap = (struct sockaddr_in *)sap;
> > + ap->sin_port = htons(port);
> > + break;
> > + }
> > + case AF_INET6: {
> > + struct sockaddr_in6 *ap = (struct sockaddr_in6 *)sap;
> > + ap->sin6_port = htons(port);
> > + break;
> > + }
> > + }
> > +}
>
> Before Trond sees this and busts a blood vessel... you should refactor
> the switch statement to get rid of the double braces.
OK, both done; results are the top four patches of
git://linux-nfs.org/~bfields/linux.git for-trond
If you have other nfs/ipv6 patches laying around, would you rather queue
these up with them and send them in to Trond yourself? Or do you want
me to? Your choice.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
