2015-07-21 23:46 GMT+09:00 Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx>: > From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > The gpiod functions include variants for managed gpiod resources. Use it > to simplify the remove function. > > As the driver handles a device node without a specification of dvs gpios > just fine, additionally use the variant of gpiod_get exactly for this > use case. This makes error checking more strict. > > As a third benefit this patch makes the driver use the flags parameter > of gpiod_get* which will not be optional any more after 4.2 and so > prevents a build failure when the respective gpiod commit is merged. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > note the above mentioned gpiod change is already in next, so the driver > fails to build there. > > Changes since (implicit) v1, sent with > Message-Id: 1437461993-14860-1-git-send-email-u.kleine-koenig@xxxxxxxxxxxxxx: > > - Assert that of_node_put is called in error path to not leak a reference > and drop now empty remove callback. > Thanks to Krzysztof Kozlowski for catching. > > > Best regards > Uwe > drivers/regulator/rk808-regulator.c | 32 ++++++++++++-------------------- > 1 file changed, 12 insertions(+), 20 deletions(-) Looks good now: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
