On Tue, Jul 21, 2015 at 12:04:15PM +0100, Mark Brown wrote: > On Tue, Jul 21, 2015 at 11:56:49AM +0200, Linus Walleij wrote: > > On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König > > > > The gpiod functions include variants for managed gpiod resources. Use it > > > to simplify the remove function. > > > > As the driver handles a device node without a specification of dvs gpios > > > just fine, additionally use the variant of gpiod_get exactly for this > > > use case. This makes error checking more strict. > > > > As a third benefit this patch makes the driver use the flags parameter > > > of gpiod_get* which will not be optional any more after 4.2 and so > > > prevents a build failure when the respective gpiod commit is merged. > > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > > Mark, please apply this. > > ...and reverted since it doesn't build as it's adding a use of a new API > which doesn't actually exist in Linus' tree yet (hopefully it's in > -next). I need a tag to pull if I'm going to use this patch. If you're refering to the build bot warning I got, too, then the problem is just a missing #include and the problem existed already before e.g. for gpiod_get_value with the .config used by the build bot. In reply to this mail I'll send a fixup patch for the missing include and a reworked version of my patch that fixes the reference leak pointed out by Krzysztof Kozlowski. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
