On Mon, Aug 12, 2013 at 09:39:01AM -0400, Peter Hurley wrote: > On 08/12/2013 09:19 AM, Sergey Senozhatsky wrote: > >On (08/12/13 08:55), Peter Hurley wrote: > >>>>>[..] > >>>>> drivers/tty/n_tty.c | 25 +++++++++++-------------- > >>>>> 1 file changed, 11 insertions(+), 14 deletions(-) > >>>>> > >>> > >>>I hate to do this, but isn't it actually my patch posted here > >>>https://lkml.org/lkml/2013/8/1/510 > >>> > >>>which was tagged as `wrong'? > >> > >>Sergey, > >> > >>My apologies; I was mistaken regarding this problem being a lockdep > >>regression (although it's still a false positive from lockdep). Once > >>I had worked around some issues with the nouveau driver, I was able to > >>reproduce the lockdep report on 3.10. > >> > >no problem. > > > >>I included Artem's lockdep report in the changelog because I received > >>that first, on 30 July. > >> > >>My patch below is not the same as your patch of 1 Aug. This patch > >>preserves the protected access of termios.c_cc[VMIN] and termios.c_cc[VTIME] > >>(via the MIN_CHAR() and TIME_CHAR() macros). > > > >fair enough. v3 was protecting VMIN/VTIME (my bad, I noticed this a bit later), > >but I didn't submit it since v2 did not get positive response. > > > >>If you'd prefer, I could add to changelog: > >> > >> Patch based on original posted here https://lkml.org/lkml/2013/8/1/510 > >> by Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> > > > >if you don't mind, that would be great. > > Ok. > > Greg, > Should I re-spin a v2 to include the note above > (or can you add it with Artem's Tested-by)? I'll add it, no need to resend. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
