On Sun 28-02-10 15:07:17, Geert Uytterhoeven wrote: > On Sun, Feb 28, 2010 at 11:04, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Thu, Feb 25, 2010 at 15:29, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > >> 2010/2/25 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>: > >>> On Thu, Feb 25, 2010 at 02:38, Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote: > >>>> 2010/2/25 Jan Kara <jack@xxxxxxx>: > >>>>> On Tue 23-02-10 23:11:13, Akinobu Mita wrote: > >>>>>> Use ext2_find_next_bit (generic_find_next_le_bit) to find the set bit > >>>>>> in little endian bitmap region. > >>> > >>> Is any of this in linux-next now? > >>> > >>> http://kisskb.ellerman.id.au/kisskb/buildresult/2208481/ > >>> | fs/udf/balloc.c:274: error: implicit declaration of function > >>> 'generic_find_next_le_bit' > >> > >> Yep, Jan's patch caused the build breakage. > >> > >> Because generic_find_next_le_bit() is not available for all > >> archtectures. So we should use ext2_find_next_bit() here. > > > > Most architectures use the definitions in asm-generic, so they're OK. > > M68k doesn't. S390 is also affected, and I think arm as well (but there's no > > arm all-modconfig build in linux-next, so I'm not 100% sure). > > > > I'm cooking a patch... > > From c9b5c7e6ef2092be822778a0b6b3d3032c058f5b Mon Sep 17 00:00:00 2001 > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Date: Sun, 28 Feb 2010 13:06:27 +0100 > Subject: [PATCH] m68k: Implement generic_find_next_{zero_,}le_bit() > > linux-next: > fs/udf/balloc.c: In function 'udf_bitmap_new_block': > fs/udf/balloc.c:274: error: implicit declaration of function > 'generic_find_next_le_bit' > > Convert ext2_find_next_{zero_,}bit() into generic_find_next_{zero_,}le_bit(), > and wrap the ext2_find_next_{zero_,}bit() around the latter. I've now used Akinobu's patch so yours isn't really needed but it's a good cleanup anyway in my opinion. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
