On Wed, Mar 11, 2009 at 09:07:28PM +1100, Greg Banks wrote: > > I think this patch does the same thing more cleanly. > > When CONFIG_DYNAMIC_DEBUG is enabled, allow callers of pr_debug() > to provide their own definition of pr_fmt() even if that definition > uses tricks like > > #define pr_fmt(fmt) "%s:" fmt, __func__ > patch looks good. I agree its simpler than what I proposed. However, I don't think we want to add pr_fmt() in the dynamic_dev_dbg() path, since dev_dbg() isn't doing that to start with. Other than that, I ack it. thanks, -Jason -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html