On Tue, 10 Mar 2009 16:29:50 +0100 (CET) Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx> wrote: > > The same could be done with the problematic pr_fmt definition: > > > > #define pr_fmt(fmt) __func__ ": " fmt > > No, that also doesn't work: > > | crypto/zlib.c:150: error: expected '}' before string constant > | crypto/zlib.c:150: error: expected ')' before '__func__' > | crypto/zlib.c:162: error: expected '}' before string constant > | crypto/zlib.c:162: error: expected ')' before '__func__' > | crypto/zlib.c:166: error: expected '}' before string constant > | crypto/zlib.c:166: error: expected ')' before '__func__' > | crypto/zlib.c:170: error: expected '}' before string constant > | crypto/zlib.c:170: error: expected ')' before '__func__' > > > > BTW, Martin: Is `#define pr_fmt(fmt) "%s: " fmt, __func__' a valid and > > > intended usage of your pr_fmt() infrastructure? > > > > The indended use is a simple prefix to the format string. To paste an > > additional parameter is an interesting use of the pr_fmt macro .. > > Bummer, I was so happy I could do things like > > | #define pr_fmt(fmt) "%s:%u: " fmt, __func__, __LINE__ Actually that seem like a nice thing to have. With the upstream version of dynamic_pr_debug this works, there the format string is used only on a printk. git commit 25b67b75587d43ff3f09ad88c03c70a38372d95d introduces the code that pastes the format string to the _ddebug structure. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
