On Tue, 10 Mar 2009, Jason Baron wrote: > On Tue, Mar 10, 2009 at 05:08:41PM +0100, Martin Schwidefsky wrote: > > On Tue, 10 Mar 2009 16:29:50 +0100 (CET) > > Geert Uytterhoeven <Geert.Uytterhoeven@xxxxxxxxxxx> wrote: > > > > > > The same could be done with the problematic pr_fmt definition: > > > > > > > > #define pr_fmt(fmt) __func__ ": " fmt > > > > > > No, that also doesn't work: > > > > > > | crypto/zlib.c:150: error: expected '}' before string constant > > > | crypto/zlib.c:150: error: expected ')' before '__func__' > > > | crypto/zlib.c:162: error: expected '}' before string constant > > > | crypto/zlib.c:162: error: expected ')' before '__func__' > > > | crypto/zlib.c:166: error: expected '}' before string constant > > > | crypto/zlib.c:166: error: expected ')' before '__func__' > > > | crypto/zlib.c:170: error: expected '}' before string constant > > > | crypto/zlib.c:170: error: expected ')' before '__func__' > > > > > > > > BTW, Martin: Is `#define pr_fmt(fmt) "%s: " fmt, __func__' a valid and > > > > > intended usage of your pr_fmt() infrastructure? > > > > > > > > The indended use is a simple prefix to the format string. To paste an > > > > additional parameter is an interesting use of the pr_fmt macro .. > > > > > > Bummer, I was so happy I could do things like > > > > > > | #define pr_fmt(fmt) "%s:%u: " fmt, __func__, __LINE__ > > > > Actually that seem like a nice thing to have. With the upstream version of > > dynamic_pr_debug this works, there the format string is used only on a printk. > > git commit 25b67b75587d43ff3f09ad88c03c70a38372d95d introduces the code > > that pastes the format string to the _ddebug structure. > > > > hmmm...yeah, some macro magic in include/linux/dynamic_debug.h converts > the 'fmt' arg into a series of strings. It doesn't look as pretty in the > dynamic debug control file: > > crypto/zlib.c:333 [zlib]zlib_decompress_final - "\042%s: \042 > \042avail_in %u, avail_out %u (consumed %u, produced %u)\n\042, > __func__" > > with all those '\042' there, which are the '"' characters, but we > probably could live with it. Ugh, not only that, it also contains the __func__. BTW, why do you store this string? The only thing you can do with it later is to print it verbatim (without % format parameter expansion), as it has swallowed the first parameter (__func__), but still contains the %s. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-next" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
