* Jarek Poplawski <jarkao2@xxxxx> wrote: > On Thu, Jul 26, 2007 at 10:31:20AM +0200, Ingo Molnar wrote: > ... > > yeah. The patch below enables sw-resend on x86, to test the theory > > whether the APIC-driven hardware-vector-resend code has some problem. > > I think Marcin is using x86_64 (Athlon 64) yet. yeah - i meant to cover both arches but forgot about x86_64 - updated patch attached below. Ingo -----------------> Subject: x86: activate HARDIRQS_SW_RESEND From: Ingo Molnar <mingo@xxxxxxx> activate the software-triggered IRQ-resend logic. it appears some chipsets/cpus do not handle local-APIC driven IRQ resends all that well, so always use the soft mechanism to trigger the execution of pending interrupts. Signed-off-by: Ingo Molnar <mingo@xxxxxxx> --- arch/i386/Kconfig | 4 ++++ arch/x86_64/Kconfig | 4 ++++ kernel/irq/manage.c | 8 ++++++++ 3 files changed, 16 insertions(+) Index: linux-rt-rebase.q/arch/i386/Kconfig =================================================================== --- linux-rt-rebase.q.orig/arch/i386/Kconfig +++ linux-rt-rebase.q/arch/i386/Kconfig @@ -1284,6 +1284,10 @@ config GENERIC_PENDING_IRQ depends on GENERIC_HARDIRQS && SMP default y +config HARDIRQS_SW_RESEND + bool + default y + config X86_SMP bool depends on SMP && !X86_VOYAGER Index: linux-rt-rebase.q/arch/x86_64/Kconfig =================================================================== --- linux-rt-rebase.q.orig/arch/x86_64/Kconfig +++ linux-rt-rebase.q/arch/x86_64/Kconfig @@ -721,6 +721,10 @@ config GENERIC_PENDING_IRQ depends on GENERIC_HARDIRQS && SMP default y +config HARDIRQS_SW_RESEND + bool + default y + menu "Power management options" source kernel/power/Kconfig Index: linux-rt-rebase.q/kernel/irq/manage.c =================================================================== --- linux-rt-rebase.q.orig/kernel/irq/manage.c +++ linux-rt-rebase.q/kernel/irq/manage.c @@ -175,6 +175,14 @@ void enable_irq(unsigned int irq) desc->depth--; } spin_unlock_irqrestore(&desc->lock, flags); +#ifdef CONFIG_HARDIRQS_SW_RESEND + /* + * Do a bh disable/enable pair to trigger any pending + * irq resend logic: + */ + local_bh_disable(); + local_bh_enable(); +#endif } EXPORT_SYMBOL(enable_irq); - To unsubscribe from this list: send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
