Hi, Please see my comments below... Friday, May 20, 2005, 12:55:20 PM, you wrote: >> So, say esp_output is called, I try to dispatch the skb to the crypto >> engine, which returns an error because it's queue is full. I then want >> to drop the frame (drop the skb) from within esp_output(). What is the >> correct way of doing this? Do I just free the skb and never call >> dst_output() with it? Are there some frame counter statistics which >> need updating to register the fact we have dropped the frame? > I can't tell you specifically as I haven't been looking at that code. > But the "out of resources" problem will most likely happen > synchronously, at least whenever I have hit resource limits on the > ixp access lib, the initial call into it fails rather than having to > wait for a callback to find out. Providing that is the case you would > handle it just as esp_output currently handles "out of resource" problems. That's correct, if I try to dispatch a buffer to the IXP crypto engine it may return an error saying the queue is full. To which I should react by dropping the skb, and return an error condition. I've been looking, and would it be a good idea to return: NET_XMIT_CN from esp_output() and/or esp_input() if I have to drop the frame because the HW crypto engine's queue is full? It looks that way, but I have no idea if the caller to esp_output() and/or esp_input() know how to react to NET_XMIT_CN. Regards, Dan... > Cheers, > Davidm - : send the line "unsubscribe linux-net" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
