-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Fri, 30 Jan 2004 15:50:35 -0800 "David S. Miller" <davem@redhat.com> wrote: >On Fri, 30 Jan 2004 13:20:39 -0800 >Stephen Hemminger <shemminger@osdl.org> wrote: > >> Right now I am testing a version that builds on 2.6, and cleans up some little things. > >Ok, you want to integrate these cleanups and fixes I made to his 2.4.x >patch. > >Angelo, in particular note that I got rid of your rwlock on the westwood >data, it isn't needed as the whole socket structure is completely locked >in every context in which your westwood code runs. Completely agree with you. Just few trivial things. I think that now few comments have to be corrected since they refer to that rwlock. Another comment to correct is this one + * TCP Westwood + * Here limit is evaluated as BWestimation*RTTmin (for obtaining it + * in packets we use mss_cache). If CONFIG_TCP_WESTWOOD is not defined + * westwood_bw_rttmin() returns 0. In such case snd_ssthresh is still + * used as usual. It prevents other strange cases in which BWE*RTTmin + * could assume value 0. It should not happen but... This is not updated since CONFIG_TCP_WESTWOOD has gone.. so here we must refer to the sysctl instead. As I read before, you sent the corrected patch to Marcelo for 2.4.26-pre1. I think these trivial corrections could be done between -pre1 and -pre2. Hope you agree. If not, I'll take care of it as soon as possible. Please let me know. Another thing. I think we should insert a few documentation about this new feature at least an explanation of the new sysctl, isn't it? Regards. - -- Angelo Dell'Aera 'buffer' Antifork Research, Inc. http://buffer.antifork.org PGP information in e-mail header -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFAG8A6pONIzxnBXKIRAi9nAJ9Nazzk+/DljzbLsvfXm/0RChD9CwCgj7CA CeKzfycTeRU3Z8H4bvaGuNg= =Ens0 -----END PGP SIGNATURE----- - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
