On Sat, 31 Jan 2004 15:48:26 +0100 "Angelo Dell'Aera" <buffer@antifork.org> wrote: > This is not updated since CONFIG_TCP_WESTWOOD has gone.. so here we must refer > to the sysctl instead. I've made the correction in my tree, see below. > As I read before, you sent the corrected patch to Marcelo > for 2.4.26-pre1. More precisely, I've put it into my pending tree which I will push to Marcelo once he is done with 2.4.25 final and begins to take 2.4.26-preX changes. > Another thing. I think we should insert a few documentation about this new > feature at least an explanation of the new sysctl, isn't it? I'll happily take a ip-sysctl.txt patch, thanks. # This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.1305 -> 1.1306 # net/ipv4/tcp_input.c 1.28 -> 1.29 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 04/02/01 davem@nuts.davemloft.net 1.1306 # [TCP]: Kill bogus reference to CONFIG_TCP_WESTWOOD. # -------------------------------------------- # diff -Nru a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c --- a/net/ipv4/tcp_input.c Sun Feb 1 11:06:37 2004 +++ b/net/ipv4/tcp_input.c Sun Feb 1 11:06:37 2004 @@ -1392,10 +1392,10 @@ /* * TCP Westwood * Here limit is evaluated as BWestimation*RTTmin (for obtaining it - * in packets we use mss_cache). If CONFIG_TCP_WESTWOOD is not defined - * westwood_bw_rttmin() returns 0. In such case snd_ssthresh is still - * used as usual. It prevents other strange cases in which BWE*RTTmin - * could assume value 0. It should not happen but... + * in packets we use mss_cache). If sysctl_tcp_westwood is off + * tcp_westwood_bw_rttmin() returns 0. In such case snd_ssthresh is + * still used as usual. It prevents other strange cases in which + * BWE*RTTmin could assume value 0. It should not happen but... */ if (!(limit = tcp_westwood_bw_rttmin(tp))) - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
