On Mon, 27 Oct 2003 22:02:46 +1100 Herbert Xu <herbert@gondor.apana.org.au> wrote: > On Mon, Oct 27, 2003 at 01:56:45AM -0800, David S. Miller wrote: > > > > It's easier to verify code when reference counts created locally > > are released locally. So xfrm_user_policy() should drop the reference > > to the policy it gets via km->compile_policy(). That is where > > the second reference count comes from right? > > Yes. And in fact that's what my second patch does. > > > What's the simplest smallest fix to get rid of the timer ref > > counting bug? Your patch here made it difficult for me to determine > > exactly what case is wrong. > > The second patch that I sent you is the largest fix but IMHO the > most maintainable. > > If you're really going for the minimal fix, then here it is. Now that I understand what is going on I like your second patch and have applied it. Thanks for your patience. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
