On Mon, 27 Oct 2003 20:50:23 +1100 Herbert Xu <herbert@gondor.apana.org.au> wrote: > Of course it's not gratuitous if it is needed. But in this particular > case there is no need for the extra bump as the policy already has a > refcount on its way in which never gets released (see the place in > xfrm_state.c where socket policies are inserted). I see, you speak of xfrm_user_policy(). It's easier to verify code when reference counts created locally are released locally. So xfrm_user_policy() should drop the reference to the policy it gets via km->compile_policy(). That is where the second reference count comes from right? What's the simplest smallest fix to get rid of the timer ref counting bug? Your patch here made it difficult for me to determine exactly what case is wrong. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
