-----BEGIN PGP SIGNED MESSAGE----- >>>>> "Herbert" == Herbert Xu <herbert@gondor.apana.org.au> writes: Herbert> http://gondor.apana.org.au/~herbert/freeswan/freeswan-linux-ipsec-20030524.1.patch.gz Herbert> and use it together with the following kernel patch against 2.5.69. Herbert, I have been reading your patches to FreeS/WAN. This is very exciting. I have some questions/comments: 1) do we really need linux/include/rtnetlink.h? Shouldn't this be coming from the kernel headers? 2) You appear to have conditionalized the scripts to live on both kernels. That's very cool, but does it make any sense to do given that pluto would seem to do one or the other? 3) I'd like to accept your patches into our tree. I would prefer that the pluto patches be at least, #ifdef'ed. Better would be if we created: kernel-klips.c kernel-netlink.c and included one or other into compilation. Best would be if we could include both, and select them at run-time via a set of function pointers. ] ON HUMILITY: to err is human. To moo, bovine. | firewalls [ ] Michael Richardson, Sandelman Software Works, Ottawa, ON |net architect[ ] mcr@sandelman.ottawa.on.ca http://www.sandelman.ottawa.on.ca/ |device driver[ ] panic("Just another Debian GNU/Linux using, kernel hacking, security guy"); [ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (GNU/Linux) Comment: Finger me for keys iQCVAwUBPtJyoYqHRg3pndX9AQEWmwP9GEdg9MLmyMOetcMRcFb1A288/PAoBPFs qTTYeyJXfRnfgPPZRNsuhOacYQj2yL1RDwGaEiOJbfGKmNomIr6hXlb5c5PTw6OS TGF8zocdK0uci3+7xAxlFG16Gp1f0DIcJsUP1IUHEKXAYmE5bZZf+g/6x5NTU0CX +2c01PE31bk= =aQuP -----END PGP SIGNATURE----- - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html