Re: [PATCH]: lru queue for ip_fragment evictor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Morton wrote:

Patrick McHardy <kaber@trash.net> wrote:

David S. Miller wrote:

Posting a patch without describing why the change is being
made is always a bad idea.  I delete such emails.  I'm stupid
and I need to be told what a patch does and why.

Sorry, i didn't meant to waste your time.
The current ip_fragment evictor kills the oldest entry of each hash bucket
starting with 0 instead of killing the oldest entry of all buckets. This leads
to unfair behaviour if one of the higher hash slots carries alot of fragments.
This patch holds the frag heads in a lru queue so we can kills the least
recently used first. Each arriving fragment counts as usage.

Does this not imply that the hash isn't very good?

No in fact it implies the hash _is_ good. The more hash buckets are in use, the more
"innocent" frag heads are killed if a high bucket uses alot of memory.

Patrick

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux