Donald Becker wrote:
>On Tue, 8 Oct 2002, Manfred Spraul wrote:
>
>
>
>>I think we have fixed the problems in 2.5.41:
>>- the eeprom timeout warning was conditional, and by default off. Now
>>they are always printed.
>>
>>
>
>I'm don't believe that putting such code in the driver is a good idea.
>
>
I don't like it either, but
- hw timeouts are bad. I've run into the timeout one night [overheating,
whatever], and it was difficult to figure out why the nic only worked in
promisc mode. The message about failed timeouts should default to on,
the message about successful load should default to off.
- the netif_msg macros do not support severity, as your "debug" variable.
Initially I used debug > 1 for the failure case, and debug > 2 (or 3)
for success. But then debug was removed :-(
--
Manfred
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
