Re: natsemi.c - multicast hash bug?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sorry about this.  The bug seems to be resolved in the 2.4.19 driver and
later.  It was a problem in earlier versions, but I cannot reproduce the
problem in the latest kernel. Sorry for not verifying that it reproduced
prior to sending the message.

Also, I failed to comprehend the code prior to posting... Confession is
good for the soul...

Nat

On Mon, 2002-12-02 at 16:14, Nat Ersoz wrote:
> Fellows,
> 
> I'm debugging a problem in the natsemi.c driver which has the symptom
> that muticast reception quits for no apparent reason.  Unicast still
> works fine, the multicast stream is being sent, but no packets make it
> past the hash filter.  In versions of the driver, 2.4.19 and before, we
> "fixed" this problem by setting ifconfig "allmuti" on the device.  
> 
> As I'm writing a debug routine, I notice that:
> 
> 
> static void __set_rx_mode(struct net_device *dev)
> {
> ...
> 
>     for (i = 0, mclist = dev->mc_list; 
>       mclist && i < dev->mc_count;
>       i++, mclist = mclist->next) {
>          set_bit_le(
>            dp83815_crc(ETH_ALEN, mclist->dmi_addr) & 0x1ff,
>            mc_filter);    /* WHOOPS!! Shouldn't this be &mc_filter[i*2] 
> ?? */
>     }
> ...
> }
> 
> (see the comment containnig WHOOPS)
> 
> Thanks,
> 
> Nat
-- 

	     

-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux