>>>>> "Paul" == Paul Gortmaker <p_gortmaker@yahoo.com> writes:
Paul> Uwe Bonnes wrote:
>> appended patch registers the IO Memory region used by the smc-ultra
>> driver. It is against 2.4.2, but applies to 2.2.18 too.
>>
>> Could anybody have a look at the patch and either forward it to Linux
>> and Alan or give me the "go" to do that?
Paul> It leaks memory (dev->priv) and mixes exit styles with what is in
Paul> use in that driver (i.e. return -EBUSY vs. retval=-EBUSY; goto
Paul> out;) and the mem region should be requested conditionally on
Paul> whether the card is in PIO or sh-mem mode.
Paul> I originally had a patch to fix three things that are rather
Paul> related. They are 1) adding request_mem_region, 2) ioremap
Paul> instead of isa_r/w and 3) purge of isa-isms like dev->rmem_* from
Paul> the netdev struct. It didn't go into 2.4 and I didn't push it,
Paul> since it wasn't a showstopper by any means (and my patch probably
Paul> had bugs too ;)
Paul> If people really want another shiny number in /proc to gawk at
Paul> (pun intended) then I'll post a 2.4.x patch for the common ISA
Paul> sh-mem 8390 cards that just adds the request_mem_region stuff.
Hallo Paul,
I think I answered you when the original thread appeared, but maybe the mail
didn't get through and I forgot to resend, as personal matters appeared end
of march. However trying to work with the pcmcia package today, I stumbled
with 2.4.7 on the same problems that was the reason for my patch.
My request doesn't go for another "shiny" number in /proc, but the pcmcia
package uses these values (if available) to decide if a region is available
for the pcmcia package. If I start pcmcia services on my system, net access
comes to a halt, as the pcmcia package reuses the area occupied by the 8390
card, as the 8390 card forgets to register itself. I can manually configure
PCMCIA to exclude that area, but I think that automatic exclusion is a
better thing...
So I still would appreciate a "2.4.x patch for the common ISA sh-mem 8390
cards"
Bye
--
Uwe Bonnes bon@elektron.ikp.physik.tu-darmstadt.de
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
