Uwe Bonnes wrote: > appended patch registers the IO Memory region used by the smc-ultra > driver. It is against 2.4.2, but applies to 2.2.18 too. > > Could anybody have a look at the patch and either forward it to Linux and > Alan or give me the "go" to do that? It leaks memory (dev->priv) and mixes exit styles with what is in use in that driver (i.e. return -EBUSY vs. retval=-EBUSY; goto out;) and the mem region should be requested conditionally on whether the card is in PIO or sh-mem mode. I originally had a patch to fix three things that are rather related. They are 1) adding request_mem_region, 2) ioremap instead of isa_r/w and 3) purge of isa-isms like dev->rmem_* from the netdev struct. It didn't go into 2.4 and I didn't push it, since it wasn't a showstopper by any means (and my patch probably had bugs too ;) If people really want another shiny number in /proc to gawk at (pun intended) then I'll post a 2.4.x patch for the common ISA sh-mem 8390 cards that just adds the request_mem_region stuff. Paul. - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org
