Andrzej Krzysztofowicz wrote:
>
> This patch adds MODULE_PARM_DESC to all drivers located directly in
> drivers/net. Some existing descriptions are fixed; some undefined
> parameters are disabled.
I almost hate to say this after you did all the editing to put these in,
but I have a suggestion. In cases like this:
> +MODULE_PARM_DESC(io, "EtherLink II I/O base address(es)");
> +MODULE_PARM_DESC(irq, "EtherLink II IRQ number(s) (assigned)");
> +MODULE_PARM_DESC(xcvr, "EtherLink II tranceiver(s) (0=internal,1=external)");
it seems redundant to put in "Etherlink II" for each option. Instead,
I would suggest adding a MODULE_DESCRIPTION (assuming there isn't one).
So for example the above becomes:
+MODULE_DESCRIPTION("Etherlink II (3c503,3c503/16) ISA Ethernet Driver");
...
+MODULE_PARM_DESC(io, "I/O base address(es)");
+MODULE_PARM_DESC(irq, "IRQ number(s) (assigned)");
+MODULE_PARM_DESC(xcvr, "Tranceiver(s) (0=internal, 1=external)");
Maybe you can take the old version of your patch and do something like:
sed 's/".*I\/O base/"I\/O base/;s/".*IRQ num/"IRQ num/' < old > new
patch -R < old
patch < new
to save a bit of editing.
Paul.
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
