Paul Gortmaker wrote:
> Andrzej Krzysztofowicz wrote:
> > +MODULE_PARM_DESC(io, "EtherLink II I/O base address(es)");
> > +MODULE_PARM_DESC(irq, "EtherLink II IRQ number(s) (assigned)");
> > +MODULE_PARM_DESC(xcvr, "EtherLink II tranceiver(s) (0=internal,1=external)");
>
> it seems redundant to put in "Etherlink II" for each option. Instead,
> I would suggest adding a MODULE_DESCRIPTION (assuming there isn't one).
> So for example the above becomes:
>
> +MODULE_DESCRIPTION("Etherlink II (3c503,3c503/16) ISA Ethernet Driver");
> ...
> +MODULE_PARM_DESC(io, "I/O base address(es)");
> +MODULE_PARM_DESC(irq, "IRQ number(s) (assigned)");
> +MODULE_PARM_DESC(xcvr, "Tranceiver(s) (0=internal, 1=external)");
>
> Maybe you can take the old version of your patch and do something like:
>
> sed 's/".*I\/O base/"I\/O base/;s/".*IRQ num/"IRQ num/' < old > new
> patch -R < old
> patch < new
>
> to save a bit of editing.
agreed
--
Jeff Garzik | Disbelief, that's why you fail.
Building 1024 |
MandrakeSoft |
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
