On 2020/4/15 13:35, Sascha Hauer wrote: > Hi Tudor, > > On Tue, Apr 14, 2020 at 04:41:42PM +0000, Tudor.Ambarus@xxxxxxxxxxxxx wrote: >> On Tuesday, April 14, 2020 3:09:45 PM EEST Sascha Hauer wrote: >>> Any feedback to this one? >> Hi, Sascha, >> >> I'm a bit busy but I'll try to allocate time to review patches sometime this >> week. BTW, we moved the manufacturer specific code out of the core, we now >> have a dedicated file for each manufacturer (this includes flash_info >> entries), check the spi-nor/next branch. > I see. It's in master now btw. > >> I know that it's not your fault that >> your patch was left behind, so I volunteer to respin your patch if you don't >> feel like doing it. > Don't worry, I can respin it. You want to have a cypress.c file, even > though it has only a single entry, right? Hi Sascha, Maybe it's okay to put in spansion.c, as Spansion/Cypress may use same manufacturer id on some flash. Otherwise, we should spilt the Cypress ones from list in spansion.c to new cypress.c. Regards, Yicong > > Sascha > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/