Re: [PATCH v2] mtd: spi-nor: Add support for cy15x104q

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

On Wednesday, April 15, 2020 8:35:27 AM EEST Sascha Hauer wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Tudor,

Hi, Sascha,

> 
> On Tue, Apr 14, 2020 at 04:41:42PM +0000, Tudor.Ambarus@xxxxxxxxxxxxx wrote:
> > On Tuesday, April 14, 2020 3:09:45 PM EEST Sascha Hauer wrote:
> > > Any feedback to this one?
> > 
> > Hi, Sascha,
> > 
> > I'm a bit busy but I'll try to allocate time to review patches sometime
> > this week. BTW, we moved the manufacturer specific code out of the core,
> > we now have a dedicated file for each manufacturer (this includes
> > flash_info entries), check the spi-nor/next branch.
> 
> I see. It's in master now btw.
> 
> > I know that it's not your fault that
> > your patch was left behind, so I volunteer to respin your patch if you
> > don't feel like doing it.
> 
> Don't worry, I can respin it. You want to have a cypress.c file, even
> though it has only a single entry, right?
> 

I think you can add this as the last entry in the spansion_parts[] array from 
spansion.c. Cypress and Spansion merged back in 2015, they are a single entity 
now. The fixup hook is not affecting this flash, we should be fine. For the 
moment I don't see a need for a spi_nor_cypress struct.

Cheers,
ta


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/