According to datasheets all GD devices are capable of quad mode, which is enabled via Status Register-2, bit 1 (S9). This corresponds to Spansion SR/CR operations. Unfortunately only gd25q256 datasheet is clear about Quad Enable Requirements (QER), others have no such information in datasheets. So define quad_enable for all GD devices to be sure. Also gd25q256 is an exception. There are two versions: C and D. First one uses S6 bit (like described in e27072851bf7d) but the latter uses S9 bit like others. To add support for D this should be handled differently, so, to retain compatibility, leave gd25q256 quad_enable callback intact. Signed-off-by: Roman Yeryomin <roman@xxxxxxxx> --- drivers/mtd/spi-nor/spi-nor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 6e13bbd1aaa5..d598efb57f20 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -1764,31 +1764,37 @@ static const struct flash_info spi_nor_ids[] = { "gd25q16", INFO(0xc84015, 0, 64 * 1024, 32, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + .quad_enable = spansion_read_cr_quad_enable, }, { "gd25q32", INFO(0xc84016, 0, 64 * 1024, 64, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + .quad_enable = spansion_read_cr_quad_enable, }, { "gd25lq32", INFO(0xc86016, 0, 64 * 1024, 64, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + .quad_enable = spansion_read_cr_quad_enable, }, { "gd25q64", INFO(0xc84017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + .quad_enable = spansion_read_cr_quad_enable, }, { "gd25lq64c", INFO(0xc86017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + .quad_enable = spansion_read_cr_quad_enable, }, { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) + .quad_enable = spansion_read_cr_quad_enable, }, { "gd25q256", INFO(0xc84019, 0, 64 * 1024, 512, -- 2.20.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/