Re: [PATCH 1/2] mtd: spi-nor: fix GigaDevice quad_enable

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

Hi, Roman,

On 07/27/2019 12:08 AM, Roman Yeryomin wrote:
> External E-Mail
> 
> 
> According to datasheets all GD devices are capable of quad mode, which

Does any of these flashes implement the Basic Flash Parameter Table? Can't we
determine the QE Requirements by parsing BFPT?

> is enabled via Status Register-2, bit 1 (S9). This corresponds to
> Spansion SR/CR operations. Unfortunately only gd25q256 datasheet is
> clear about Quad Enable Requirements (QER), others have no such
> information in datasheets.
> So define quad_enable for all GD devices to be sure.

Which flash did you test?

Cheers,
ta

> Also gd25q256 is an exception. There are two versions: C and D.
> First one uses S6 bit (like described in e27072851bf7d) but the latter
> uses S9 bit like others. To add support for D this should be handled
> differently, so, to retain compatibility, leave gd25q256 quad_enable
> callback intact.
> 
> Signed-off-by: Roman Yeryomin <roman@xxxxxxxx>
> ---
>  drivers/mtd/spi-nor/spi-nor.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/