On 5/22/19 5:20 PM, Kees Cook wrote: > On Wed, May 22, 2019 at 11:57:38PM +0200, Boris Brezillon wrote: >> All this look suspicious, and even if the fall through logic >> has no side effects in practice (which I'm still not sure is the case), >> I think it'd be better to explicitly set the flags that have >> to be set in each case statement and add breaks. > > Yeah, totally agreed. :) > Thank you, Kees and Boris for the feedback. Some external opinions were certainly much needed here. I'll just wait for any comments from the MTD guys. Thanks -- Gustavo ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/