Re: [PATCH 03/14] mtd: rawnand: gpmi: move all driver code into single file

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Sascha,

Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote on Tue, 21 May 2019
10:34:21 +0200:

> On Tue, May 21, 2019 at 09:06:32AM +0200, Sascha Hauer wrote:
> > This moves the whole driver into a single C file. The filename gpmi-lib
> > implies that it implements library functions, but in fact there are
> > several cases where functions in gpmi-lib.c call back into functions in
> > gpmi-nand.c. With this one has to constantly jump between those two
> > files, so moving it into a single file improves readability, even when
> > the file gets quite large.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> >  drivers/mtd/nand/raw/gpmi-nand/Makefile    |    1 -
> >  drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c  |  923 --------------
> >  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 1269 +++++++++++++++++---
> >  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h |   34 -
> >  4 files changed, 1095 insertions(+), 1132 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/raw/gpmi-nand/Makefile b/drivers/mtd/nand/raw/gpmi-nand/Makefile
> > index 3a462487c35e..60c7b6f87c53 100644
> > --- a/drivers/mtd/nand/raw/gpmi-nand/Makefile
> > +++ b/drivers/mtd/nand/raw/gpmi-nand/Makefile
> > @@ -1,3 +1,2 @@
> >  obj-$(CONFIG_MTD_NAND_GPMI_NAND) += gpmi_nand.o
> >  gpmi_nand-objs += gpmi-nand.o
> > -gpmi_nand-objs += gpmi-lib.o
> > diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > index a8b26d2e793c..bcc92185384a 100644
> > --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-lib.c
> > @@ -9,926 +9,3 @@
> >  #include <linux/clk.h>
> >  #include <linux/slab.h>  
> 
> Oops, gpmi-lib.c should be completely removed here. Please use the
> following version of this patch.
> 

Done.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/