Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

On Mon, 20 Aug 2018 12:21:12 +0000
Naga Sureshkumar Relli <nagasure@xxxxxxxxxx> wrote:

> Hi Boris,
> 
> > -----Original Message-----
> > From: Boris Brezillon [mailto:boris.brezillon@xxxxxxxxxxx]
> > Sent: Monday, August 20, 2018 5:40 PM
> > To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> > Cc: richard@xxxxxx; absahu@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > marek.vasut@xxxxxxxxx; kyungmin.park@xxxxxxxxxxx; frieder.schrempf@xxxxxxxxx; linux-
> > mtd@xxxxxxxxxxxxxxxxxxx; miquel.raynal@xxxxxxxxxxx; nagasureshkumarrelli@xxxxxxxxx;
> > Michal Simek <michals@xxxxxxxxxx>; computersforpeace@xxxxxxxxx; dwmw2@xxxxxxxxxxxxx;
> > peterpandong@xxxxxxxxxx
> > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan
> > NAND Flash Controller
> > 
> > On Mon, 20 Aug 2018 10:49:38 +0000
> > Naga Sureshkumar Relli <nagasure@xxxxxxxxxx> wrote:
> >   
> > >
> > > Thanks for your suggestion and are you saying something like Marvell parser patterns for  
> > nfcv1 as below?  
> > >
> > > static const struct nand_op_parser marvell_nfcv1_op_parser = NAND_OP_PARSER(
> > > 	/* Naked commands not supported, use a function for each pattern */
> > > 	NAND_OP_PARSER_PATTERN(
> > > 		marvell_nfc_read_id_type_exec,
> > > 		NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > > 		NAND_OP_PARSER_PAT_ADDR_ELEM(false,  
> > MAX_ADDRESS_CYC_NFCV1),  
> > > 		NAND_OP_PARSER_PAT_DATA_IN_ELEM(false, 8)),
> > > 	NAND_OP_PARSER_PATTERN(
> > > 		marvell_nfc_erase_cmd_type_exec,
> > > 		NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > > 		NAND_OP_PARSER_PAT_ADDR_ELEM(false,  
> > MAX_ADDRESS_CYC_NFCV1),  
> > > 		NAND_OP_PARSER_PAT_CMD_ELEM(false),
> > > 		NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)),
> > > 	);
> > > That means, a separate hook for each pattern, is that you are suggesting?  
> > 
> > Yes.  
> 
> Ok, I will update the driver and will send next version.

Wait a bit before sending a new version, there were other things I
wanted to comment on, this one was just the main issue.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/