On Mon, Feb 11, 2013 at 5:41 PM, Dmitry V. Levin <ldv@xxxxxxxxxxxx> wrote: > On Mon, Feb 11, 2013 at 03:07:52PM -0300, Cristian Rodríguez wrote: >> "The secure_getenv() function is intended for use in general-purpose >> libraries to avoid vulnerabilities that could occur if set-user-ID or >> set-group-ID programs accidentally trusted the environment." > [...] >> +#ifndef HAVE_SECURE_GETENV >> +# ifdef HAVE__SECURE_GETENV should be HAVE___SECURE_GETENV >> +# define secure_getenv __secure_getenv >> +# else >> +# warning neither secure_getenv nor __secure_getenv are available in your libc. >> +#define secure_getenv getenv > > The change by itself is correct, but the grammar and indentation are not. > Something like this would be more appropriate: > > +# warning neither secure_getenv nor __secure_getenv is available > +# define secure_getenv getenv I fixed it all and pushed (additionally removing the s-o-b) thanks. Lucas De Marchi -- To unsubscribe from this list: send the line "unsubscribe linux-modules" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
