Re: [PATCH] libkmod: Use secure_getenv if available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 11, 2013 at 03:07:52PM -0300, Cristian Rodríguez wrote:
> "The secure_getenv() function is intended for use in general-purpose
> libraries to avoid vulnerabilities that could occur if set-user-ID or
> set-group-ID programs accidentally trusted the environment."
[...]
> +#ifndef HAVE_SECURE_GETENV
> +#  ifdef HAVE__SECURE_GETENV
> +#    define secure_getenv __secure_getenv
> +#  else
> +#    warning neither secure_getenv nor __secure_getenv are available in your libc.
> +#define secure_getenv getenv

The change by itself is correct, but the grammar and indentation are not.
Something like this would be more appropriate:

+#    warning neither secure_getenv nor __secure_getenv is available
+#    define secure_getenv getenv


-- 
ldv

Attachment: pgpHLYjlmCSa8.pgp
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux