Am 01.03.24 um 17:35 schrieb Fiona Klute:
Am 01.03.24 um 03:09 schrieb Ping-Ke Shih:
-----Original Message-----
From: Fiona Klute <fiona.klute@xxxxxx>
Sent: Wednesday, February 28, 2024 7:55 AM
To: linux-wireless@xxxxxxxxxxxxxxx; Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Cc: Fiona Klute <fiona.klute@xxxxxx>; kvalo@xxxxxxxxxx;
ulf.hansson@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx;
pavel@xxxxxx; megi@xxxxxx
Subject: [PATCH v2 4/9] wifi: rtw88: Add rtw8703b.h
This is the main header for the new rtw88_8703b chip driver.
Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Tested-by: Pavel Machek <pavel@xxxxxx>
Signed-off-by: Fiona Klute <fiona.klute@xxxxxx>
---
drivers/net/wireless/realtek/rtw88/rtw8703b.h | 103 ++++++++++++++++++
1 file changed, 103 insertions(+)
create mode 100644 drivers/net/wireless/realtek/rtw88/rtw8703b.h
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8703b.h
b/drivers/net/wireless/realtek/rtw88/rtw8703b.h
new file mode 100644
index 00000000000..69dac101d33
--- /dev/null
+++ b/drivers/net/wireless/realtek/rtw88/rtw8703b.h
@@ -0,0 +1,103 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
+/* Copyright Fiona Klute <fiona.klute@xxxxxx> */
+
+#ifndef __RTW8703B_H__
+#define __RTW8703B_H__
+
+#include <linux/types.h>
+#include <linux/compiler_attributes.h>
Removing these two headers can still compiled pass in my side. Please
check why
you need them.
If I remove them whether the code compiles depends on the order of
#includes. If some other header that includes those two is included
before rtw8703b.h it works, otherwise it will break. I don't think
that's desirable, though other rtw88 headers already behave that way
(e.g. main.h must be included before the others). Also, clangd will
complain about undefined types (u8, s8), which is less important but
still annoying when working on the code. So I'd prefer to keep the
includes.
Correction: Only the linux/types.h is needed for that, I can definitely
remove the linux/compiler_attributes.h one.
