On Fri, 2024-03-01 at 18:15 +0100, Fiona Klute wrote: > > Am 01.03.24 um 17:35 schrieb Fiona Klute: > > > > If I remove them whether the code compiles depends on the order of > > #includes. If some other header that includes those two is included > > before rtw8703b.h it works, otherwise it will break. I don't think > > that's desirable, though other rtw88 headers already behave that way > > (e.g. main.h must be included before the others). Also, clangd will > > complain about undefined types (u8, s8), which is less important but > > still annoying when working on the code. So I'd prefer to keep the > > includes. > > Correction: Only the linux/types.h is needed for that, I can definitely > remove the linux/compiler_attributes.h one. > Please check mail that explains what I meant.
