Re: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 01.03.24 um 05:36 schrieb Ping-Ke Shih:
-----Original Message-----
From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Sent: Friday, March 1, 2024 10:33 AM
To: Fiona Klute <fiona.klute@xxxxxx>; linux-wireless@xxxxxxxxxxxxxxx
Cc: kvalo@xxxxxxxxxx; ulf.hansson@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; pavel@xxxxxx; megi@xxxxxx
Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c



-----Original Message-----
From: Fiona Klute <fiona.klute@xxxxxx>
Sent: Wednesday, February 28, 2024 7:55 AM
To: linux-wireless@xxxxxxxxxxxxxxx; Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Cc: Fiona Klute <fiona.klute@xxxxxx>; kvalo@xxxxxxxxxx; ulf.hansson@xxxxxxxxxx;
linux-mmc@xxxxxxxxxxxxxxx;
pavel@xxxxxx; megi@xxxxxx
Subject: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c

+
+#define TRANS_SEQ_END                  \
+       {0xFFFF,                        \
+        RTW_PWR_CUT_ALL_MSK,           \
+        RTW_PWR_INTF_ALL_MSK,          \
+        0,                             \
+        RTW_PWR_CMD_END, 0, 0}

Move this macro to main.h along with RTW_PWR_CUT_ALL_MSK.

Think of this again, I prefer removing braces
#define TRANS_SEQ_END			\
	 0xFFFF,			\
	 RTW_PWR_CUT_ALL_MSK,		\
	 RTW_PWR_INTF_ALL_MSK,		\
	 0,				\
	 RTW_PWR_CMD_END, 0, 0

Okay, will do that. And it gets rid of the odd "tab plus space" indent
for most of the definition. :-)






[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux