> -----Original Message-----
> From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Sent: Friday, March 1, 2024 10:33 AM
> To: Fiona Klute <fiona.klute@xxxxxx>; linux-wireless@xxxxxxxxxxxxxxx
> Cc: kvalo@xxxxxxxxxx; ulf.hansson@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; pavel@xxxxxx; megi@xxxxxx
> Subject: RE: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
>
>
>
> > -----Original Message-----
> > From: Fiona Klute <fiona.klute@xxxxxx>
> > Sent: Wednesday, February 28, 2024 7:55 AM
> > To: linux-wireless@xxxxxxxxxxxxxxx; Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> > Cc: Fiona Klute <fiona.klute@xxxxxx>; kvalo@xxxxxxxxxx; ulf.hansson@xxxxxxxxxx;
> linux-mmc@xxxxxxxxxxxxxxx;
> > pavel@xxxxxx; megi@xxxxxx
> > Subject: [PATCH v2 5/9] wifi: rtw88: Add rtw8703b.c
> >
> > +
> > +#define TRANS_SEQ_END \
> > + {0xFFFF, \
> > + RTW_PWR_CUT_ALL_MSK, \
> > + RTW_PWR_INTF_ALL_MSK, \
> > + 0, \
> > + RTW_PWR_CMD_END, 0, 0}
>
> Move this macro to main.h along with RTW_PWR_CUT_ALL_MSK.
Think of this again, I prefer removing braces
#define TRANS_SEQ_END \
0xFFFF, \
RTW_PWR_CUT_ALL_MSK, \
RTW_PWR_INTF_ALL_MSK, \
0, \
RTW_PWR_CMD_END, 0, 0
Then, consumers look like
static const struct rtw_pwr_seq_cmd trans_carddis_to_cardemu_8703b[] = {
{0x0005,
RTW_PWR_CUT_ALL_MSK,
RTW_PWR_INTF_ALL_MSK,
RTW_PWR_ADDR_MAC,
RTW_PWR_CMD_WRITE, BIT(7), 0},
{TRANS_SEQ_END}, // <=== This one will be consistent with others.
};
Ping-Ke
