On 2023/3/6 22:04, Conor Dooley wrote:
> Hey William,
>
> On Thu, Feb 16, 2023 at 11:31:45AM +0100, Krzysztof Kozlowski wrote:
>> On 16/02/2023 11:29, Conor Dooley wrote:
>> > On Thu, Feb 16, 2023 at 11:23:00AM +0100, Krzysztof Kozlowski wrote:
>> >> On 15/02/2023 12:32, William Qiu wrote:
>> >>> Add documentation to describe StarFive System Controller Registers.
>> >>>
>> >>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
>> >>> ---
>> >>
>> >> Thank you for your patch. There is something to discuss/improve.
>
> Could you please submit a v5 of this, with the bits below fixed,
> whenever Hal sends their next version of the base dts series?
> There's no maintainers coverage for a soc/starfive subdirectory of
> dt-bindings yet, so please CC conor@xxxxxxxxxx &
> linux-riscv@xxxxxxxxxxxxxxxxxxx on the patch.
>
> Thanks,
> Conor.
>
I'll do it today.
Best regards
William
>> >>
>> >>> +properties:
>> >>> + compatible:
>> >>> + items:
>> >>> + - enum:
>> >>> + - starfive,jh7110-stg-syscon
>> >>> + - starfive,jh7110-sys-syscon
>> >>> + - starfive,jh7110-aon-syscon
>> >>
>> >> Maybe keep them ordered alphabetically?
>> >>
>> >>> + - const: syscon
>> >>> +
>> >>> + reg:
>> >>> + maxItems: 1
>> >>> +
>> >>> +required:
>> >>> + - compatible
>> >>> + - reg
>> >>> +
>> >>> +additionalProperties: false
>> >>> +
>> >>> +examples:
>> >>> + - |
>> >>> + syscon@10240000 {
>> >>> + compatible = "starfive,jh7110-stg-syscon", "syscon";
>> >>> + reg = <0x10240000 0x1000>;
>> >>> + };
>> >>
>> >> Keep only one example. All others are the same.
>> >
>> > With these fixed:
>> > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
>> >
>> > @Krzysztof, I assume the location of the binding is okay with you since
>> > you didn't object to it & I suppose this one is up to me to apply if so.
>>
>> Yeah, generic sysreg devices go to soc. If their primary functions were
>> different (e.g. clock controller which also is syscon), then they should
>> go to respective directories, but it's not the case here, I think.
>>
>> Best regards,
>> Krzysztof
>>
>>
