On Thu, Feb 16, 2023 at 11:23:00AM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2023 12:32, William Qiu wrote:
> > Add documentation to describe StarFive System Controller Registers.
> >
> > Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx>
> > ---
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - starfive,jh7110-stg-syscon
> > + - starfive,jh7110-sys-syscon
> > + - starfive,jh7110-aon-syscon
>
> Maybe keep them ordered alphabetically?
>
> > + - const: syscon
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + syscon@10240000 {
> > + compatible = "starfive,jh7110-stg-syscon", "syscon";
> > + reg = <0x10240000 0x1000>;
> > + };
>
> Keep only one example. All others are the same.
With these fixed:
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
@Krzysztof, I assume the location of the binding is okay with you since
you didn't object to it & I suppose this one is up to me to apply if so.
Cheers,
Conor.
Attachment:
signature.asc
Description: PGP signature
